gianm commented on code in PR #13887:
URL: https://github.com/apache/druid/pull/13887#discussion_r1142886040
##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchMergeAggregator.java:
##########
@@ -58,12 +58,20 @@ public ArrayOfDoublesSketchMergeAggregator(
@Override
public void aggregate()
{
- final ArrayOfDoublesSketch update = selector.getObject();
+ final Object update = selector.getObject();
if (update == null) {
return;
}
+ final ArrayOfDoublesSketch sketch;
+ if (update instanceof ArrayOfDoublesSketch) {
Review Comment:
It's not documented, IIRC because we are still sorting out what the best way
is to expose this to end users, so we might need to change the API. It is fine
for use in a unit test though. If we change the API we'll update the test too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
