github-code-scanning[bot] commented on code in PR #13947:
URL: https://github.com/apache/druid/pull/13947#discussion_r1143221795
##########
processing/src/test/java/org/apache/druid/math/expr/ApplyFunctionTest.java:
##########
@@ -48,7 +48,7 @@
builder.put("d", new String[] {null});
builder.put("e", new String[] {null, "foo", "bar"});
builder.put("f", new String[0]);
- bindings = InputBindings.withMap(builder.build());
+ bindings = InputBindings.forMap(builder.build());
Review Comment:
## Deprecated method or constructor invocation
Invoking [InputBindings.forMap](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4416)
##########
processing/src/test/java/org/apache/druid/math/expr/EvalTest.java:
##########
@@ -143,7 +144,7 @@
@Test
public void testLongEval()
{
- Expr.ObjectBinding bindings = InputBindings.withMap(ImmutableMap.of("x",
9223372036854775807L));
+ Expr.ObjectBinding bindings = InputBindings.forMap(ImmutableMap.of("x",
9223372036854775807L));
Review Comment:
## Deprecated method or constructor invocation
Invoking [InputBindings.forMap](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4418)
##########
processing/src/test/java/org/apache/druid/math/expr/EvalTest.java:
##########
@@ -76,7 +77,7 @@
@Test
public void testDoubleEval()
{
- Expr.ObjectBinding bindings = InputBindings.withMap(ImmutableMap.of("x",
2.0d));
+ Expr.ObjectBinding bindings = InputBindings.forMap(ImmutableMap.of("x",
2.0d));
Review Comment:
## Deprecated method or constructor invocation
Invoking [InputBindings.forMap](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4417)
##########
processing/src/test/java/org/apache/druid/math/expr/EvalTest.java:
##########
@@ -624,7 +623,7 @@
bindingsMap.put("s2", "false");
bindingsMap.put("b1", true);
bindingsMap.put("b2", false);
- Expr.ObjectBinding bindings = InputBindings.withMap(bindingsMap);
+ Expr.ObjectBinding bindings = InputBindings.forMap(bindingsMap);
Review Comment:
## Deprecated method or constructor invocation
Invoking [InputBindings.forMap](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4421)
##########
processing/src/test/java/org/apache/druid/math/expr/FunctionTest.java:
##########
@@ -82,7 +82,7 @@
.put("someComplex", new
TypeStrategiesTest.NullableLongPair(1L, 2L))
.put("str1", "v1")
.put("str2", "v2");
- bindings = InputBindings.withMap(builder.build());
+ bindings = InputBindings.forMap(builder.build());
Review Comment:
## Deprecated method or constructor invocation
Invoking [InputBindings.forMap](1) should be avoided because it has been
deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4422)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
