abhishekagarwal87 commented on code in PR #13973:
URL: https://github.com/apache/druid/pull/13973#discussion_r1147437143
##########
extensions-core/druid-pac4j/src/main/java/org/apache/druid/security/pac4j/OIDCConfig.java:
##########
@@ -35,16 +35,21 @@
@JsonProperty
private final String discoveryURI;
+ @JsonProperty
+ private final String scope;
+
@JsonCreator
public OIDCConfig(
@JsonProperty("clientID") String clientID,
@JsonProperty("clientSecret") PasswordProvider clientSecret,
- @JsonProperty("discoveryURI") String discoveryURI
+ @JsonProperty("discoveryURI") String discoveryURI,
+ @JsonProperty("scope") String scope
)
{
this.clientID = Preconditions.checkNotNull(clientID, "null clientID");
this.clientSecret = Preconditions.checkNotNull(clientSecret, "null
clientSecret");
this.discoveryURI = Preconditions.checkNotNull(discoveryURI, "null
discoveryURI");
+ this.scope = Preconditions.checkNotNull(scope, "null scope");
Review Comment:
null scope should be allowed or otherwise existing installations will break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
