somu-imply commented on code in PR #13965:
URL: https://github.com/apache/druid/pull/13965#discussion_r1148160452
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -7306,21 +7306,26 @@ public void testMinMaxAvgDailyCountWithLimit()
)
)
.setInterval(querySegmentSpec(Filtration.eternity()))
- .setLimitSpec(
- new DefaultLimitSpec(
- ImmutableList.of(),
- 1
- )
- )
.setGranularity(Granularities.ALL)
.setAggregatorSpecs(
+ useDefault ?
aggregators(
new LongMaxAggregatorFactory("_a0", "a0"),
new LongMinAggregatorFactory("_a1", "a0"),
new LongSumAggregatorFactory("_a2:sum", "a0"),
new CountAggregatorFactory("_a2:count"),
new LongMaxAggregatorFactory("_a3", "d0"),
new CountAggregatorFactory("_a4")
+ ) : aggregators(
+ new LongMaxAggregatorFactory("_a0", "a0"),
+ new LongMinAggregatorFactory("_a1", "a0"),
+ new LongSumAggregatorFactory("_a2:sum", "a0"),
+ new FilteredAggregatorFactory(
+ new CountAggregatorFactory("_a2:count"),
+ not(selector("a0", null, null))
+ ),
+ new LongMaxAggregatorFactory("_a3", "d0"),
+ new CountAggregatorFactory("_a4")
Review Comment:
No clue but in the case of the useDefault=false it uses the same thing but
with a check of not null so thought it was kind of correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
