clintropolis commented on code in PR #13803:
URL: https://github.com/apache/druid/pull/13803#discussion_r1148809855
##########
processing/src/main/java/org/apache/druid/math/expr/ExprEval.java:
##########
@@ -370,6 +370,18 @@ public static ExprEval ofComplex(ExpressionType
outputType, @Nullable Object val
return new ComplexExprEval(outputType, value);
}
+ public static ExprEval bestEffortArray(@Nullable List<?> theList)
+ {
+ // do not convert empty lists to arrays with a single null element here,
because that should have been done
+ // by the selectors preparing their ObjectBindings if necessary. If we get
to this point it was legitimately
+ // empty
+ NonnullPair<ExpressionType, Object[]> coerced = coerceListToArray(theList,
false);
+ if (coerced == null) {
+ return bestEffortOf(null);
Review Comment:
I think it would probably be best to have null handled first in
`bestEffortOf` so that if we ever decide to represent `null` as something more
sensible (like introduce a null type), we won't be making a 'string' here, not
to mention the saving of not running through a bunch of checks for a null value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
