gianm commented on code in PR #13955:
URL: https://github.com/apache/druid/pull/13955#discussion_r1149811243
##########
extensions-contrib/aliyun-oss-extensions/src/test/java/org/apache/druid/data/input/aliyun/OssInputSourceTest.java:
##########
@@ -318,6 +324,13 @@ public void testSerdeWithOtherOtherInvalidArgs()
@Test
public void testWithUrisSplit()
{
+ EasyMock.reset(OSSCLIENT);
Review Comment:
> How would we test this to make sure it actually works against Alibaba
Object Storage Service? We know that it works against mocks. Does it work
against the real service?
I don't know; I'm not familiar with this service. I tried to keep the
changes for this extension minimal, given we don't have automated integration
tests.
> There is no test here to limit the number of items returned. Should there
be?
I didn't see such a feature of the OssInputSource, but I might have missed
it… which feature are you talking about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
