gianm commented on code in PR #13955:
URL: https://github.com/apache/druid/pull/13955#discussion_r1149877538
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/input/SlicerUtils.java:
##########
@@ -35,7 +35,7 @@
*
* Items are assigned round-robin.
*/
- public static <T> List<List<T>> makeSlices(final Iterator<T> iterator, final
int numSlices)
+ public static <T> List<List<T>> makeSlicesStatic(final Iterator<T> iterator,
final int numSlices)
Review Comment:
There's no negotiation at this time; the controller comes up with a number
of tasks it wants (up to the user-provided `maxNumTasks` setting) and then
launches those tasks. A negotiation would be neat but would require more
Overlord support than is currently possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
