zachjsh commented on code in PR #14003:
URL: https://github.com/apache/druid/pull/14003#discussion_r1157520353
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialDimensionDistributionTask.java:
##########
@@ -174,6 +176,22 @@ public String getType()
return TYPE;
}
+ @JsonIgnore
+ @Nullable
+ @Override
+ public Set<String> getInputSourceTypes()
+ {
+ return getIngestionSchema().getIOConfig().getInputSource() != null ?
Review Comment:
These task definitions are a little brittle, think this would be a little
risky to do at this time.
##########
server/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorSpec.java:
##########
@@ -71,6 +73,15 @@ default boolean isSuspended()
*/
String getType();
+ @Nullable
+ default Set<String> getInputSourceTypes() {
+ return null;
+ }
+
+ default boolean usesFirehose() {
+ return false;
+ }
Review Comment:
added comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
