zachjsh commented on code in PR #14003:
URL: https://github.com/apache/druid/pull/14003#discussion_r1157859165
##########
server/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorSpec.java:
##########
@@ -71,6 +74,25 @@ default boolean isSuspended()
*/
String getType();
+ /**
+ * @return The types of {@link org.apache.druid.data.input.InputSource} that
the task uses. Empty set is returned if
+ * the task does not use any. Users can be given permission to access
particular types of
+ * input sources but not others, using the
+ * {@link
org.apache.druid.server.security.AuthConfig#enableInputSourceSecurity} config.
+ */
+ default Set<String> getInputSourceTypes() {
Review Comment:
Good suggestion, fixed.
##########
server/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorSpec.java:
##########
@@ -71,6 +74,25 @@ default boolean isSuspended()
*/
String getType();
+ /**
+ * @return The types of {@link org.apache.druid.data.input.InputSource} that
the task uses. Empty set is returned if
+ * the task does not use any. Users can be given permission to access
particular types of
+ * input sources but not others, using the
+ * {@link
org.apache.druid.server.security.AuthConfig#enableInputSourceSecurity} config.
+ */
+ default Set<String> getInputSourceTypes() {
+ return ImmutableSet.of();
+ }
+
+ /**
+ * @return Whether the task uses {@link
org.apache.druid.data.input.Firehose}. If the
+ * {@link
org.apache.druid.server.security.AuthConfig#enableInputSourceSecurity} config is
+ * enabled, then tasks that use firehose cannot be used.
+ */
+ default boolean usesFirehose() {
Review Comment:
Good suggestion, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
