clintropolis commented on code in PR #14021: URL: https://github.com/apache/druid/pull/14021#discussion_r1158841812
########## processing/src/test/java/org/apache/druid/segment/SimpleStorageAdapterTest.java: ########## @@ -19,27 +19,41 @@ package org.apache.druid.segment; -import org.apache.druid.collections.bitmap.BitmapFactory; -import org.apache.druid.segment.column.ColumnHolder; +import org.apache.druid.java.util.common.granularity.Granularity; +import org.apache.druid.java.util.common.guava.Sequence; +import org.apache.druid.query.QueryMetrics; +import org.apache.druid.query.filter.Filter; +import org.apache.druid.segment.column.ColumnCapabilities; import org.apache.druid.segment.data.Indexed; +import org.joda.time.DateTime; import org.joda.time.Interval; import org.junit.Assert; import org.junit.Test; import javax.annotation.Nullable; -import java.util.List; -import java.util.Map; -public class SimpleQueryableIndexTest +public class SimpleStorageAdapterTest Review Comment: hmm, i'm not sure this rename makes sense, there is a `SimpleQueryableIndex` but there is no such named storage adapter, though looking at it i'm not sure the name made sense in the first place since it wasn't making a `SimpleQueryableIndex` 🙃 How about naming this something about tombstones? Or just moving this check into `QueryableIndexStorageAdapterTest`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
