rohangarg commented on code in PR #14063:
URL: https://github.com/apache/druid/pull/14063#discussion_r1162824021
##########
services/src/main/java/org/apache/druid/cli/CliPeon.java:
##########
@@ -144,10 +143,10 @@ public class CliPeon extends GuiceRunnable
{
@SuppressWarnings("WeakerAccess")
@Required
- @Arguments(description = "baseTaskDirPath taskId attemptId")
+ @Arguments(description = "taskDirPath attemptId")
public List<String> taskAndStatusFile;
- // path to the base task Directory
+ // path to the task Directory
private String taskDirPath;
Review Comment:
I have some difficulty understanding the connection of this path with the
intermediate directories being created by the task. This path would have been
derived from the multiple directory selection algorithm present in the task
runners. Although, `CliPeon` also injects `TaskConfig` object as a config
object which means that config object wouldn't have the directory selection
logic present.
Is there some place which modifies the `TaskConfig` object to override its
`baseTaskDirPath` with the path given in the task launcher command line?
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/config/TaskConfig.java:
##########
@@ -118,18 +121,10 @@
@JsonProperty
private final boolean encapsulatedTask;
- @Deprecated
- @JsonProperty("baseTaskDir")
- private final String baseTaskDirPath;
-
- // Use multiple base files for tasks instead of a single one
- @JsonProperty
- private final List<String> baseTaskDirPaths;
-
@JsonCreator
public TaskConfig(
@JsonProperty("baseDir") String baseDir,
- @Deprecated @JsonProperty("baseTaskDir") String baseTaskDirPath,
+ @JsonProperty("baseTaskDir") String baseTaskDir,
Review Comment:
should this still be deprecated as a json config for configuring task
locations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
