imply-cheddar commented on code in PR #14063:
URL: https://github.com/apache/druid/pull/14063#discussion_r1163251651
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/config/TaskConfig.java:
##########
@@ -118,18 +121,10 @@
@JsonProperty
private final boolean encapsulatedTask;
- @Deprecated
- @JsonProperty("baseTaskDir")
- private final String baseTaskDirPath;
-
- // Use multiple base files for tasks instead of a single one
- @JsonProperty
- private final List<String> baseTaskDirPaths;
-
@JsonCreator
public TaskConfig(
@JsonProperty("baseDir") String baseDir,
- @Deprecated @JsonProperty("baseTaskDir") String baseTaskDirPath,
+ @JsonProperty("baseTaskDir") String baseTaskDir,
Review Comment:
No, it should be overridden on the TaskConfig object that is sent to the
tasks. Let me make sure that I'm doing that properly, I might've overlooked it
as I got bogged down in the degree of sprawl that this PR has.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
