abhishekagarwal87 commented on code in PR #13358:
URL: https://github.com/apache/druid/pull/13358#discussion_r1164021382
##########
server/src/main/java/org/apache/druid/curator/announcement/Announcer.java:
##########
@@ -314,7 +313,7 @@ public void childEvent(CuratorFramework client,
PathChildrenCacheEvent event) th
if (oldBytes == null) {
created = true;
} else if (!Arrays.equals(oldBytes, bytes)) {
- throw new IAE("Cannot reannounce different values under the same
path");
+ log.error("Ignoring attempt to announce different values under same
path");
Review Comment:
it's called 4 times. From my local logs of a run
```
2023-03-22T13:24:51,527 INFO [main]
org.apache.druid.curator.discovery.CuratorDruidNodeAnnouncer - Announced self
[{"druidNode":{"service":"druid/coordinator","host":"localhost","bindOnHost":false,"plaintextPort":8081,"port":-1,"tlsPort":-1,"enablePlaintextPort":true,"enableTlsPort":false},"nodeType":"coordinator","services":{}}].
2023-03-22T13:24:51,530 INFO [main]
org.apache.druid.curator.discovery.CuratorDruidNodeAnnouncer - Announced self
[{"druidNode":{"service":"druid/coordinator","host":"localhost","bindOnHost":false,"plaintextPort":8081,"port":-1,"tlsPort":-1,"enablePlaintextPort":true,"enableTlsPort":false},"nodeType":"overlord","services":{}}].
2023-03-22T13:24:51,530 INFO [main]
org.apache.druid.curator.discovery.CuratorDruidNodeAnnouncer - Announced self
[{"druidNode":{"service":"druid/coordinator","host":"localhost","bindOnHost":false,"plaintextPort":8081,"port":-1,"tlsPort":-1,"enablePlaintextPort":true,"enableTlsPort":false},"nodeType":"coordinator","services":{}}].
2023-03-22T13:24:51,530 INFO [main]
org.apache.druid.curator.discovery.CuratorDruidNodeAnnouncer - Announced self
[{"druidNode":{"service":"druid/coordinator","host":"localhost","bindOnHost":false,"plaintextPort":8081,"port":-1,"tlsPort":-1,"enablePlaintextPort":true,"enableTlsPort":false},"nodeType":"overlord","services":{}}].
```
I debugged this a bit and you are right about it being called from two
modules. I think that we can also skip the duplicate announcement when Overlord
is not in standalone mode. That should fix the problem you ran into. And we
keep this assert in place. what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
