abhishekagarwal87 commented on code in PR #13358:
URL: https://github.com/apache/druid/pull/13358#discussion_r1165265412


##########
server/src/main/java/org/apache/druid/curator/announcement/Announcer.java:
##########
@@ -314,7 +313,7 @@ public void childEvent(CuratorFramework client, 
PathChildrenCacheEvent event) th
         if (oldBytes == null) {
           created = true;
         } else if (!Arrays.equals(oldBytes, bytes)) {
-          throw new IAE("Cannot reannounce different values under the same 
path");
+          log.error("Ignoring attempt to announce different values under same 
path");

Review Comment:
   I tried this change and it's working fine. 
   
   ```
   diff --git a/services/src/main/java/org/apache/druid/cli/CliOverlord.java 
b/services/src/main/java/org/apache/druid/cli/CliOverlord.java
   index e4383c673c..79b90e63b5 100644
   --- a/services/src/main/java/org/apache/druid/cli/CliOverlord.java
   +++ b/services/src/main/java/org/apache/druid/cli/CliOverlord.java
   @@ -267,13 +267,13 @@ public class CliOverlord extends ServerRunnable
    
                if (standalone) {
                  LifecycleModule.register(binder, Server.class);
   -            }
    
   -            bindAnnouncer(
   -                binder,
   -                IndexingService.class,
   -                DiscoverySideEffectsProvider.create()
   -            );
   +              bindAnnouncer(
   +                      binder,
   +                      IndexingService.class,
   +                      DiscoverySideEffectsProvider.create()
   +              );
   +            }
    
                Jerseys.addResource(binder, SelfDiscoveryResource.class);
                LifecycleModule.registerKey(binder, 
Key.get(SelfDiscoveryResource.class));
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to