vtlim commented on code in PR #14023: URL: https://github.com/apache/druid/pull/14023#discussion_r1164462933
########## docs/api-reference/api.md: ########## @@ -1,7 +1,7 @@ --- id: api Review Comment: Since this is being moved into a new section, what about also giving it a more descriptive ID? For example, "sql-ingestion-api"? ########## docs/api-reference/tasks.md: ########## @@ -1,6 +1,7 @@ --- id: tasks Review Comment: Do we want to move this page over completely, or just the Tasks API section? There seems to be a lot in this doc that isn't API focused, like how the task lock system works. It actually seems that the Task API section points to the [API reference page](https://druid.apache.org/docs/latest/operations/api-reference.html#tasks) already, so this change may not be needed. ########## docs/tutorials/tutorial-rollup.md: ########## @@ -1,7 +1,7 @@ --- id: tutorial-rollup -title: "Tutorial: Roll-up" -sidebar_label: "Roll-up" +title: Rollup Review Comment: Whatever we decide, we should standardize for other tutorials, though the quickstart(s) may not need the tutorial label. ########## docs/tutorials/tutorial-rollup.md: ########## @@ -1,7 +1,7 @@ --- id: tutorial-rollup -title: "Tutorial: Roll-up" -sidebar_label: "Roll-up" +title: Rollup Review Comment: Should we leave some sort of tutorial descriptor in the title? I think it could help set apart from the rollup conceptual doc: https://spectacular-dieffenbachia-f33981.netlify.app/docs/ingestion/rollup.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
