techdocsmith commented on code in PR #14023:
URL: https://github.com/apache/druid/pull/14023#discussion_r1197049156
##########
docs/ingestion/ingestion-spec.md:
##########
@@ -223,7 +223,7 @@ A `dimensionsSpec` can have the following components:
|------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------|
| `dimensions` | A list of [dimension names or
objects](#dimension-objects). You cannot include the same column in both
`dimensions` and `dimensionExclusions`.<br /><br />If `dimensions` and
`spatialDimensions` are both null or empty arrays, Druid treats all columns
other than timestamp or metrics that do not appear in `dimensionExclusions` as
String-typed dimension columns. See [inclusions and
exclusions](#inclusions-and-exclusions) for details.<br /><br />As a best
practice, put the most frequently filtered dimensions at the beginning of the
dimensions list. In this case, it would also be good to consider
[`partitioning`](partitioning.md) by those same dimensions.
| `[]` |
| `dimensionExclusions` | The names of dimensions to exclude from ingestion.
Only names are supported here, not objects.<br /><br />This list is only used
if the `dimensions` and `spatialDimensions` lists are both null or empty
arrays; otherwise it is ignored. See [inclusions and
exclusions](#inclusions-and-exclusions) below for details.
| `[]`
|
-| `spatialDimensions` | An array of [spatial
dimensions](../development/geo.md).
| `[]` |
+| `spatialDimensions` | An array of [spatial
dimensions](../querying/geo.md).
| `[]` |
| `includeAllDimensions` | Note that this field only applies to string-based
schema discovery where Druid ingests dimensions it discovers as strings. This
is different from schema auto-discovery where Druid infers the type for data.
You can set `includeAllDimensions` to true to ingest both explicit dimensions
in the `dimensions` field and other dimensions that the ingestion task
discovers from input data. In this case, the explicit dimensions will appear
first in the order that you specify them, and the dimensions dynamically
discovered will come after. This flag can be useful especially with auto schema
discovery using [`flattenSpec`](./data-formats.html#flattenspec). If this is
not set and the `dimensions` field is not empty, Druid will ingest only
explicit dimensions. If this is not set and the `dimensions` field is empty,
all discovered dimensions will be ingested. | false |
Review Comment:
```suggestion
| `includeAllDimensions` | Note that this field only applies to string-based
schema discovery where Druid ingests dimensions it discovers as strings. This
is different from schema auto-discovery where Druid infers the type for data.
You can set `includeAllDimensions` to true to ingest both explicit dimensions
in the `dimensions` field and other dimensions that the ingestion task
discovers from input data. In this case, the explicit dimensions will appear
first in the order that you specify them, and the dimensions dynamically
discovered will come after. This flag can be useful especially with auto schema
discovery using [`flattenSpec`](./data-formats.md#flattenspec). If this is not
set and the `dimensions` field is not empty, Druid will ingest only explicit
dimensions. If this is not set and the `dimensions` field is empty, all
discovered dimensions will be ingested. | false |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
