cryptoe commented on code in PR #14089:
URL: https://github.com/apache/druid/pull/14089#discussion_r1167354619
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialSegmentMergeTask.java:
##########
@@ -294,7 +300,20 @@ private Set<DataSegment> mergeAndPushSegments(
exception -> !(exception instanceof NullPointerException) &&
exception instanceof Exception,
5
);
+ long pushFinishTime = System.nanoTime();
pushedSegments.add(segment);
+ LOG.info(
+ "Segment[%s] of %,d bytes "
+ + "built from %d partial segment(s) in %,dms; "
+ + "pushed to deep storage in %,dms. "
+ + "Load spec is: %s",
+ segment.getId(),
+ segment.getSize(),
+ segmentFilesToMerge.size(),
+ (mergeFinishTime - startTime) / 1000000,
+ (pushFinishTime - mergeFinishTime) / 1000000,
+ jsonMapper.writeValueAsString(segment.getLoadSpec())
Review Comment:
Should we also log the interval ?
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialSegmentMergeTask.java:
##########
@@ -294,7 +300,20 @@ private Set<DataSegment> mergeAndPushSegments(
exception -> !(exception instanceof NullPointerException) &&
exception instanceof Exception,
5
);
+ long pushFinishTime = System.nanoTime();
pushedSegments.add(segment);
+ LOG.info(
+ "Segment[%s] of %,d bytes "
+ + "built from %d partial segment(s) in %,dms; "
+ + "pushed to deep storage in %,dms. "
+ + "Load spec is: %s",
+ segment.getId(),
+ segment.getSize(),
+ segmentFilesToMerge.size(),
+ (mergeFinishTime - startTime) / 1000000,
+ (pushFinishTime - mergeFinishTime) / 1000000,
+ jsonMapper.writeValueAsString(segment.getLoadSpec())
Review Comment:
Why do we want to log the loadspec ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
