imply-cheddar commented on code in PR #14089:
URL: https://github.com/apache/druid/pull/14089#discussion_r1169543455


##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialSegmentMergeTask.java:
##########
@@ -266,6 +267,12 @@ private Set<DataSegment> mergeAndPushSegments(
             persistDir,
             0
         );
+        long mergeFinishTime = System.nanoTime();
+        LOG.info("Merging [%d] input segment(s) for interval [%s] took 
[%,d]ms.",

Review Comment:
   Sorry for the really nitty nit, but this message initially made me think 
that it was in the future rather than past tense.  What do you think about 
making this
   
   ```
   "Merged [%,d] input segments for interval [%s] in [%,d]ms"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to