kfaraz commented on code in PR #13967:
URL: https://github.com/apache/druid/pull/13967#discussion_r1170064520
##########
server/src/main/java/org/apache/druid/client/DataSourcesSnapshot.java:
##########
@@ -123,6 +216,70 @@ public ImmutableSet<DataSegment> getOvershadowedSegments()
return overshadowedSegments;
}
+ public Map<String, Set<SegmentId>> getHandedOffStatePerDataSource()
+ {
+ return handedOffStatePerDataSource;
+ }
+
+ public CircularBuffer<ChangeRequestHistory.Holder<List<DataSegmentChange>>>
getChanges()
+ {
+ return changes;
+ }
+
+ public ChangeRequestsSnapshot<DataSegmentChange>
getChangesSince(ChangeRequestHistory.Counter counter)
Review Comment:
Why do we need this logic here? Can't we use the existing logic in
`ChangeRequestHistory`? If not, we should consider moving this logic to that
class anyway under a new method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
