kfaraz commented on code in PR #13967:
URL: https://github.com/apache/druid/pull/13967#discussion_r1170081005
##########
server/src/main/java/org/apache/druid/discovery/DruidLeaderClient.java:
##########
@@ -256,6 +265,80 @@ public String findCurrentLeader()
);
}
+ public InputStream getThingsFromLeaderNode(String query)
Review Comment:
Try to common out code from these two methods. They seem to be the same
except for the construction of the parser iterator.
##########
processing/src/main/java/org/apache/druid/query/QueryContext.java:
##########
@@ -577,6 +577,11 @@ public String getBrokerServiceName()
return getString(QueryContexts.BROKER_SERVICE_NAME);
}
+ public QueryContexts.UnavailableSegmentsAction getUnavailableSegmentsAction()
+ {
+ return
QueryContexts.UnavailableSegmentsAction.fromString(getString(QueryContexts.UNAVAILABLE_SEGMENTS_ACTION_KEY));
Review Comment:
Use `QueryContexts.getAsEnum` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
