LakshSingla commented on code in PR #13952: URL: https://github.com/apache/druid/pull/13952#discussion_r1170822169
########## processing/src/test/java/org/apache/druid/query/scan/ConcatCursorTest.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.scan; + +import com.google.common.collect.ImmutableList; +import org.apache.druid.segment.Cursor; +import org.apache.druid.segment.ListCursor; +import org.junit.Assert; +import org.junit.Test; + +import java.util.ArrayList; +import java.util.List; + +public class ConcatCursorTest +{ + @Test + public void testCursor() + { + Cursor dummyCursor1 = new ListCursor(new ArrayList<>()); + Cursor cursor1 = new ListCursor(ImmutableList.of("a", "b")); + Cursor dummyCursor2 = new ListCursor(new ArrayList<>()); + Cursor cursor2 = new ListCursor(ImmutableList.of("c", "d")); + Cursor dummyCursor3 = new ListCursor(new ArrayList<>()); + + Cursor concatCursor = new ConcatCursor(ImmutableList.of( + dummyCursor1, + cursor1, + dummyCursor2, + cursor2, + dummyCursor3 + )); + + List<Object> tempList = new ArrayList<>(); + // Initial iteration + while (!concatCursor.isDone()) { + tempList.add(concatCursor.getColumnSelectorFactory().makeColumnValueSelector("ignored").getObject()); Review Comment: I think this would be done implicitly when we assert the contents, since on each iteration we are adding the element to the list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
