This is an automated email from the ASF dual-hosted git repository.
vogievetsky pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 4fffee1776 Web console: better lookup 404 detection (#14108)
4fffee1776 is described below
commit 4fffee17761286996a8c43154b72db4bcaafb16d
Author: Vadim Ogievetsky <[email protected]>
AuthorDate: Wed Apr 19 09:27:55 2023 -0700
Web console: better lookup 404 detection (#14108)
* better lookup 404 detection
* update snapshot
---
web-console/src/utils/druid-lookup.ts | 4 +++-
.../src/views/lookups-view/__snapshots__/lookups-view.spec.tsx.snap | 2 +-
web-console/src/views/lookups-view/lookups-view.tsx | 6 +-----
3 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/web-console/src/utils/druid-lookup.ts
b/web-console/src/utils/druid-lookup.ts
index 990881a47f..6560ab0a6e 100644
--- a/web-console/src/utils/druid-lookup.ts
+++ b/web-console/src/utils/druid-lookup.ts
@@ -16,6 +16,8 @@
* limitations under the License.
*/
+import { deepGet } from './object-change';
+
export function isLookupsUninitialized(error: Error | undefined) {
- return error && error.message === 'Request failed with status code 404';
+ return deepGet(error || {}, 'response.status') === 404;
}
diff --git
a/web-console/src/views/lookups-view/__snapshots__/lookups-view.spec.tsx.snap
b/web-console/src/views/lookups-view/__snapshots__/lookups-view.spec.tsx.snap
index 4f8bde6b34..5dbee9dd83 100755
---
a/web-console/src/views/lookups-view/__snapshots__/lookups-view.spec.tsx.snap
+++
b/web-console/src/views/lookups-view/__snapshots__/lookups-view.spec.tsx.snap
@@ -210,7 +210,7 @@ exports[`LookupsView matches snapshot 1`] = `
multiSort={true}
nestingLevelKey="_nestingLevel"
nextText="Next"
- noDataText=""
+ noDataText="No lookups"
ofText="of"
onFetchData={[Function]}
onFilteredChange={[Function]}
diff --git a/web-console/src/views/lookups-view/lookups-view.tsx
b/web-console/src/views/lookups-view/lookups-view.tsx
index 70d0c3f6b1..524203372a 100644
--- a/web-console/src/views/lookups-view/lookups-view.tsx
+++ b/web-console/src/views/lookups-view/lookups-view.tsx
@@ -355,11 +355,7 @@ export class LookupsView extends
React.PureComponent<LookupsViewProps, LookupsVi
<ReactTable
data={lookups}
loading={lookupEntriesAndTiersState.loading}
- noDataText={
- !lookupEntriesAndTiersState.loading && !lookups.length
- ? 'No lookups'
- : lookupEntriesAndTiersState.getErrorMessage() || ''
- }
+ noDataText={lookupEntriesAndTiersState.getErrorMessage() || 'No
lookups'}
filterable
filtered={lookupFilter}
onFilteredChange={filtered => {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
