abhishekagarwal87 commented on code in PR #14040:
URL: https://github.com/apache/druid/pull/14040#discussion_r1172632633
##########
processing/src/main/java/org/apache/druid/tasklogs/TaskLogStreamer.java:
##########
@@ -44,4 +44,9 @@ default Optional<InputStream> streamTaskReports(final String
taskid) throws IOEx
{
return Optional.absent();
}
+
+ default Optional<InputStream> streamTaskStatus(final String taskid) throws
IOException
Review Comment:
javadocs for devs who would want to implement this method
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3TaskLogs.java:
##########
@@ -141,6 +148,14 @@ public void pushTaskReports(String taskid, File
reportFile) throws IOException
pushTaskFile(reportFile, taskKey);
}
+ @Override
+ public void pushTaskStatus(String taskid, File statusFile) throws IOException
+ {
+ final String taskKey = getTaskLogKey(taskid, "status.json");
+ log.info("Pushing task status %s to: %s", statusFile, taskKey);
+ pushTaskFile(statusFile, taskKey);
+ }
Review Comment:
could this be the default implementation?
##########
processing/src/main/java/org/apache/druid/tasklogs/TaskLogPusher.java:
##########
@@ -35,4 +35,8 @@
default void pushTaskReports(String taskid, File reportFile) throws
IOException
{
}
+
+ default void pushTaskStatus(String taskid, File reportFile) throws
IOException
Review Comment:
these new methods need javadocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
