nlippis commented on code in PR #14040:
URL: https://github.com/apache/druid/pull/14040#discussion_r1175624780


##########
processing/src/main/java/org/apache/druid/tasklogs/TaskLogPusher.java:
##########
@@ -35,4 +35,8 @@
   default void pushTaskReports(String taskid, File reportFile) throws 
IOException
   {
   }
+
+  default void pushTaskStatus(String taskid, File reportFile) throws 
IOException

Review Comment:
   Can we put together a follow up PR that adds javadocs to all of these 
methods.



##########
processing/src/main/java/org/apache/druid/tasklogs/TaskLogStreamer.java:
##########
@@ -44,4 +44,9 @@ default Optional<InputStream> streamTaskReports(final String 
taskid) throws IOEx
   {
     return Optional.absent();
   }
+
+  default Optional<InputStream> streamTaskStatus(final String taskid) throws 
IOException

Review Comment:
   Can we put together a follow up PR that adds javadocs to all of these 
methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to