abhishekagarwal87 commented on code in PR #14151:
URL: https://github.com/apache/druid/pull/14151#discussion_r1176106309
##########
processing/src/main/java/org/apache/druid/query/timeboundary/TimeBoundaryQueryRunnerFactory.java:
##########
@@ -155,26 +158,31 @@ public Iterator<Result<TimeBoundaryResultValue>> make()
"Null storage adapter found. Probably trying to issue a
query against a segment being memory unmapped."
);
}
- final DateTime minTime;
- final DateTime maxTime;
-
- if (legacyQuery.getFilter() != null ||
!queryIntervalContainsAdapterInterval()) {
- minTime = getTimeBoundary(adapter, legacyQuery, false);
- if (minTime == null) {
- maxTime = null;
- } else {
- maxTime = getTimeBoundary(adapter, legacyQuery, true);
+
+ DateTime minTime = null;
+ DateTime maxTime = null;
+
+ if (canUseAdapterMinMaxTime(query, adapter)) {
+ if (!query.isMaxTime()) {
+ minTime = adapter.getMinTime();
Review Comment:
should we update the docs or even the method name for
StorageAdapter#getMinTime and StorageAdapter#getMaxTime to say that
- getMinTime can return a value that is lower than the actual min time of
the data
- getMaxTime can return a value that is higher than the actual max time of
the data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
