kfaraz commented on code in PR #13840:
URL: https://github.com/apache/druid/pull/13840#discussion_r1184559655
##########
indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopTuningConfig.java:
##########
@@ -130,7 +142,8 @@ public HadoopTuningConfig(
final @JsonProperty("logParseExceptions") @Nullable Boolean
logParseExceptions,
final @JsonProperty("maxParseExceptions") @Nullable Integer
maxParseExceptions,
final @JsonProperty("useYarnRMJobStatusFallback") @Nullable Boolean
useYarnRMJobStatusFallback,
- final @JsonProperty("awaitSegmentAvailabilityTimeoutMillis") @Nullable
Long awaitSegmentAvailabilityTimeoutMillis
+ final @JsonProperty("awaitSegmentAvailabilityTimeoutMillis") @Nullable
Long awaitSegmentAvailabilityTimeoutMillis,
+ final @JsonProperty("samplingFactor") int samplingFactor
Review Comment:
Also, I think the property should be nullable. If not specified, it would
default to 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
