rohangarg commented on code in PR #14237:
URL: https://github.com/apache/druid/pull/14237#discussion_r1190243508
##########
processing/src/main/java/org/apache/druid/segment/join/JoinableFactoryWrapper.java:
##########
@@ -178,15 +183,37 @@ static JoinClauseToFilterConversion convertJoinToFilter(
}
numValues -= columnValuesWithUniqueFlag.getColumnValues().size();
- filters.add(Filters.toFilter(new InDimFilter(leftColumn,
columnValuesWithUniqueFlag.getColumnValues())));
+ // For each column value which are received in order we increment the
index
+ // and add it in the appropriate index in the map
+ int c = 0;
+ for (String val : columnValuesWithUniqueFlag.getColumnValues()) {
Review Comment:
Yes, agree with Gian's comment. Just thinking, can there be another solution
to have the `in` filters but also retain the join incase
`clause.getCondition().getEquiConditions().size() > 1`? That way we could send
some filtering down to the scan cursor and do the remaining one in the join
cursor for correctness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
