somu-imply commented on code in PR #14237:
URL: https://github.com/apache/druid/pull/14237#discussion_r1190244144
##########
processing/src/main/java/org/apache/druid/segment/join/table/IndexedTableJoinable.java:
##########
@@ -105,7 +106,7 @@ public ColumnValuesWithUniqueFlag
getNonNullColumnValues(String columnName, fina
try (final IndexedTable.Reader reader =
table.columnReader(columnPosition)) {
// Sorted set to encourage "in" filters that result from this method to
do dictionary lookups in order.
// The hopes are that this will improve locality and therefore improve
performance.
- final Set<String> allValues = createValuesSet();
+ final Set<String> allValues = createOrderedValuesSet();
Review Comment:
Makes sense, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
