kfaraz commented on code in PR #14235:
URL: https://github.com/apache/druid/pull/14235#discussion_r1192117299
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/DurableStorageCleaner.java:
##########
@@ -75,66 +72,58 @@ public boolean isEnabled()
}
@Override
- public void schedule(ScheduledExecutorService exec)
+ public void run()
{
- LOG.info("Starting the DurableStorageCleaner with the config [%s]",
config);
+ try {
Review Comment:
Edit: The implementation of both the existing duties actually throw
unchecked IOException, and it is best to just handle them in the respective
duties rather than adding `IOException` to the signature of
`OverlordDuty.run()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
