gianm commented on PR #14281:
URL: https://github.com/apache/druid/pull/14281#issuecomment-1548772012

   > Should I explicitly filter this new event type from these emitters?
   
   IMO it would make more sense to edit those emitters to ignore unknown event 
types.
   
   Btw, this may be OK for your use case, but, I wanted to point out that there 
is a race here: it's possible for the segments to be committed and for the 
server to crash before it emits this event. So, some might get missed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to