github-code-scanning[bot] commented on code in PR #14281:
URL: https://github.com/apache/druid/pull/14281#discussion_r1194473065
##########
extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitter.java:
##########
@@ -173,38 +195,87 @@
EventMap map = event.toMap();
if (config.getClusterName() != null) {
map = map.asBuilder()
- .put("clusterName", config.getClusterName())
- .build();
+ .put("clusterName", config.getClusterName())
+ .build();
}
- String resultJson = jsonMapper.writeValueAsString(map);
-
- ObjectContainer<String> objectContainer = new ObjectContainer<>(
- resultJson,
- StringUtils.toUtf8(resultJson).length
+ byte[] resultBytes = jsonMapper.writeValueAsBytes(map);
+ ObjectContainer<byte[]> objectContainer = new ObjectContainer<>(
+ resultBytes,
+ resultBytes.length
);
+ Set<EventType> eventTypes = config.getEventTypes();
if (event instanceof ServiceMetricEvent) {
- if (!metricQueue.offer(objectContainer)) {
+ if (!eventTypes.contains(EventType.METRICS) ||
!metricQueue.offer(objectContainer)) {
metricLost.incrementAndGet();
}
} else if (event instanceof AlertEvent) {
- if (!alertQueue.offer(objectContainer)) {
+ if (!eventTypes.contains(EventType.ALERTS) ||
!alertQueue.offer(objectContainer)) {
alertLost.incrementAndGet();
}
} else if (event instanceof RequestLogEvent) {
- if (config.getRequestTopic() == null ||
!requestQueue.offer(objectContainer)) {
+ if (!eventTypes.contains(EventType.REQUESTS) ||
!requestQueue.offer(objectContainer)) {
requestLost.incrementAndGet();
}
+ } else if (event instanceof SegmentMetadataEvent) {
+ if (!eventTypes.contains(EventType.SEGMENTMETADATA)) {
+ segmentMetadataLost.incrementAndGet();
+ } else {
+ switch (config.getSegmentMetadataTopicFormat()) {
+ case PROTOBUF:
+ resultBytes =
convertMetadataEventToProto((SegmentMetadataEvent) event, segmentMetadataLost);
+ objectContainer = new ObjectContainer<>(
+ resultBytes,
+ resultBytes.length
+ );
+ break;
+ case JSON:
+ // Do Nothing. We already have the JSON object stored in
objectContainer
+ break;
+ default:
+ throw new
UnsupportedOperationException("segmentMetadata.topic.format has an invalid
value " + config.getSegmentMetadataTopicFormat().toString());
+ }
+ if (!segmentMetadataQueue.offer(objectContainer)) {
+ segmentMetadataLost.incrementAndGet();
+ }
+ }
} else {
invalidLost.incrementAndGet();
}
}
- catch (JsonProcessingException e) {
+ catch (Exception e) {
invalidLost.incrementAndGet();
+ log.warn(e, "Exception while serializing event");
}
}
}
+ private byte[] convertMetadataEventToProto(SegmentMetadataEvent event,
AtomicLong segmentMetadataLost)
Review Comment:
## Useless parameter
The parameter 'segmentMetadataLost' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4964)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
