georgew5656 commented on code in PR #14285:
URL: https://github.com/apache/druid/pull/14285#discussion_r1198141850
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/KubernetesPeonClient.java:
##########
@@ -120,22 +120,46 @@ public boolean deletePeonJob(K8sTaskId taskId)
}
}
- public Optional<InputStream> getPeonLogs(K8sTaskId taskId)
+ public Optional<LogWatch> getPeonLogWatcher(K8sTaskId taskId)
{
KubernetesClient k8sClient = clientApi.getClient();
try {
LogWatch logWatch = k8sClient.batch()
+ .v1()
+ .jobs()
+ .inNamespace(namespace)
+ .withName(taskId.getK8sTaskId())
Review Comment:
this is a overall potential problem with the implementation (since we always
look for jobs running in kubernetes by their shortened-task-id name), currently
I don't think its too much of a issue because the stripped punctuation don't
affect the uniqueness of task ids. the shortening can affect this, although all
the task ids i've seen are either shorter than 63 characters or left pack their
uniqueness (at the beginning of the task id).
i'll try to think of a solution to this but i think it'll have to be a
separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
