georgew5656 commented on code in PR #14285:
URL: https://github.com/apache/druid/pull/14285#discussion_r1198285119
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/KubernetesPeonClient.java:
##########
@@ -120,22 +120,46 @@ public boolean deletePeonJob(K8sTaskId taskId)
}
}
- public Optional<InputStream> getPeonLogs(K8sTaskId taskId)
+ public Optional<LogWatch> getPeonLogWatcher(K8sTaskId taskId)
{
KubernetesClient k8sClient = clientApi.getClient();
try {
LogWatch logWatch = k8sClient.batch()
+ .v1()
Review Comment:
@suneet-s for now i'm gonna push a version of this that loads everything
into memory again so this at least works properly.
I personally think it would be okay for us to keep a longer lived copy of
KubernetesClient around somewhere to facilitate streaming but I'll have to
think about that some more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
