PramodSSImmaneni commented on code in PR #14298:
URL: https://github.com/apache/druid/pull/14298#discussion_r1199655965
##########
docs/development/extensions-core/kafka-supervisor-reference.md:
##########
@@ -198,7 +198,7 @@ The `tuningConfig` is optional and default parameters will
be used if no `tuning
| `maxRowsInMemory` | Integer | The number of rows to
aggregate before persisting. This number is the post-aggregation rows, so it is
not equivalent to the number of input events, but the number of aggregated rows
that those events result in. This is used to manage the required JVM heap size.
Maximum heap memory usage for indexing scales with `maxRowsInMemory` * (2 +
`maxPendingPersists`). Normally user does not need to set this, but depending
on the nature of data, if rows are short in terms of bytes, user may not want
to store a million rows in memory and this value should be set.
| no (default ==
1000000)
|
| `maxBytesInMemory` | Long | The number of bytes to
aggregate in heap memory before persisting. This is based on a rough estimate
of memory usage and not actual usage. Normally this is computed internally and
user does not need to set it. The maximum heap memory usage for indexing is
`maxBytesInMemory` * (2 + `maxPendingPersists`).
| no (default ==
One-sixth of max JVM memory)
|
| `maxRowsPerSegment` | Integer | The number of rows to
aggregate into a segment; this number is post-aggregation rows. Handoff will
happen either if `maxRowsPerSegment` or `maxTotalRows` is hit or every
`intermediateHandoffPeriod`, whichever happens earlier.
| no (default ==
5000000)
|
-| `maxTotalRows` | Long | The number of rows to
aggregate across all segments; this number is post-aggregation rows. Handoff
will happen either if `maxRowsPerSegment` or `maxTotalRows` is hit or every
`intermediateHandoffPeriod`, whichever happens earlier.
| no (default ==
unlimited)
|
+| `maxTotalRows` | Long | The number of rows to
aggregate across all segments; this number is post-aggregation rows. Handoff
will happen either if `maxRowsPerSegment` or `maxTotalRows` is hit or every
`intermediateHandoffPeriod`, whichever happens earlier.
| no (default == 20000000)
|
Review Comment:
@ektravel It may be confusing to say "..post-aggregation rows to
aggregate...". I was changing only the default value. The same phrase "this
number is post-aggregation rows" is also being used for maxRowsPerSegment field
description just before the maxTotalRows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
