LakshSingla commented on PR #13952: URL: https://github.com/apache/druid/pull/13952#issuecomment-1561537779
Thanks for the reviews! Post the latest batch of changes, here are the major things that I have updated: 1. Create a `FrameBasedIndexedTable` to create an indexed table based on Frame datasource. This also changed the Frame type to COLUMNAR since to index the table we need to get COLUMNs corresponding to the indexed keys. 2. Use a memory allocator factory to allow flexibility in converting the inline results to the frames 3. Added configurations, need to provide the fallback code paths as well. 4. Refactored the code and stylistic changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
