github-code-scanning[bot] commented on code in PR #14337:
URL: https://github.com/apache/druid/pull/14337#discussion_r1204985979
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java:
##########
@@ -364,7 +364,14 @@
final Set<DataSegment> updatedUsedSegments =
retrieveUsedSegments(requestKey);
if (updatedUsedSegments.equals(usedSegments)) {
- requestBatch.failPendingRequests("Allocation failed probably due to
conflicting segments.");
+ log.warn(
+ "Completing [%d] failed requests in batch [%s] with null value as
there"
+ + " are conflicting segments. Cannot retry allocation until the set
of"
+ + " used segments overlapping the allocation interval [%s] changes.",
+ size(), requestBatch, requestBatch.key.preferredAllocationInterval
Review Comment:
## Use of default toString()
Default toString(): AllocateRequestBatch inherits toString() from Object,
and so is not suitable for printing.
[Show more
details](https://github.com/apache/druid/security/code-scanning/4987)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
