TSFenwick commented on code in PR #14131:
URL: https://github.com/apache/druid/pull/14131#discussion_r1210847538
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -129,8 +129,12 @@ public TaskStatus runTask(TaskToolbox toolbox) throws
Exception
// Kill segments
toolbox.getTaskActionClient().submit(new SegmentNukeAction(new
HashSet<>(unusedSegments)));
- for (DataSegment segment : unusedSegments) {
- toolbox.getDataSegmentKiller().kill(segment);
+ if (getContextValue("batchDelete", false)) {
Review Comment:
@gianm I decided to enable this by default and not have a feature flag for
it at all. The api that is used to delete multiple keys from a bucket is
already used elsewhere in the extension.
I added that verbiage for kill not require additional permissions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
