TSFenwick commented on code in PR #14131:
URL: https://github.com/apache/druid/pull/14131#discussion_r1182839947
##########
extensions-core/s3-extensions/src/test/java/org/apache/druid/storage/s3/S3DataSegmentKillerTest.java:
##########
@@ -213,4 +219,96 @@ public void
test_killAll_nonrecoverableExceptionWhenListingObjects_deletesAllSeg
Assert.assertTrue(ioExceptionThrown);
EasyMock.verify(s3Client, segmentPusherConfig, inputDataConfig);
}
+
+ @Test
+ public void test_kill_singleSegment_doesntexist_passes() throws
SegmentLoadingException
+ {
+ EasyMock.expect(s3Client.doesObjectExist(TEST_BUCKET,
KEY_1_PATH)).andReturn(false);
+ EasyMock.expectLastCall().once();
+ EasyMock.expect(s3Client.doesObjectExist(TEST_BUCKET,
KEY_1_DESCRIPTOR_PATH)).andReturn(false);
+ EasyMock.expectLastCall().once();
+ EasyMock.replay(s3Client, segmentPusherConfig, inputDataConfig);
+
+ segmentKiller = new S3DataSegmentKiller(Suppliers.ofInstance(s3Client),
segmentPusherConfig, inputDataConfig);
+ segmentKiller.kill(DATA_SEGMENT);
+ }
+
+ @Test
+ public void test_kill_singleSegment_exists_passes() throws
SegmentLoadingException
+ {
+ EasyMock.expect(s3Client.doesObjectExist(TEST_BUCKET,
KEY_1_PATH)).andReturn(true);
+ EasyMock.expectLastCall().once();
+
+ s3Client.deleteObject(TEST_BUCKET, KEY_1_PATH);
+ EasyMock.expectLastCall().andVoid();
+
+ EasyMock.expect(s3Client.doesObjectExist(TEST_BUCKET,
KEY_1_DESCRIPTOR_PATH)).andReturn(true);
+ EasyMock.expectLastCall().once();
+
+ s3Client.deleteObject(TEST_BUCKET, KEY_1_DESCRIPTOR_PATH);
+ EasyMock.expectLastCall().andVoid();
+
+ EasyMock.replay(s3Client, segmentPusherConfig, inputDataConfig);
+
+ segmentKiller = new S3DataSegmentKiller(Suppliers.ofInstance(s3Client),
segmentPusherConfig, inputDataConfig);
+ segmentKiller.kill(DATA_SEGMENT);
+ }
+
+ @Test
+ public void test_kill_listOfOneSegment() throws SegmentLoadingException
+ {
+ EasyMock.expect(s3Client.doesObjectExist(TEST_BUCKET,
KEY_1_PATH)).andReturn(true);
+ EasyMock.expectLastCall().once();
+
+ s3Client.deleteObject(TEST_BUCKET, KEY_1_PATH);
+ EasyMock.expectLastCall().andVoid();
+
+ EasyMock.expect(s3Client.doesObjectExist(TEST_BUCKET,
KEY_1_DESCRIPTOR_PATH)).andReturn(true);
+ EasyMock.expectLastCall().once();
+
+ s3Client.deleteObject(TEST_BUCKET, KEY_1_DESCRIPTOR_PATH);
+ EasyMock.expectLastCall().andVoid();
+
+
+ EasyMock.replay(s3Client, segmentPusherConfig, inputDataConfig);
+ segmentKiller = new S3DataSegmentKiller(Suppliers.ofInstance(s3Client),
segmentPusherConfig, inputDataConfig);
+ segmentKiller.kill(ImmutableList.of(DATA_SEGMENT));
+ }
+
+ @Test
+ public void test_kill_listOfNoSegments() throws SegmentLoadingException
+ {
+ EasyMock.replay(s3Client, segmentPusherConfig, inputDataConfig);
+ segmentKiller = new S3DataSegmentKiller(Suppliers.ofInstance(s3Client),
segmentPusherConfig, inputDataConfig);
+ segmentKiller.kill(ImmutableList.of());
+ // has an assertion error if there is an unexpected method call on a mock.
Do nothing because we expect the kill
+ // method to not interact with mocks
+ }
+
+ @Test
+ public void test_kill_listOfSegments() throws SegmentLoadingException
+ {
+ DeleteObjectsRequest deleteObjectsRequest = new
DeleteObjectsRequest(TEST_BUCKET);
+ deleteObjectsRequest.withKeys(KEY_1_PATH, KEY_1_PATH);
+ // struggled with the idea of making it match on equaling this
+ s3Client.deleteObjects(EasyMock.anyObject(DeleteObjectsRequest.class));
+ EasyMock.expectLastCall().andVoid().times(2);
+
+
+ EasyMock.replay(s3Client, segmentPusherConfig, inputDataConfig);
+ segmentKiller = new S3DataSegmentKiller(Suppliers.ofInstance(s3Client),
segmentPusherConfig, inputDataConfig);
+ segmentKiller.kill(ImmutableList.of(DATA_SEGMENT, DATA_SEGMENT));
+ }
+
Review Comment:
add negative test cases with MultiPartObject Delete Exception thrown, and
AmazonServiceException Thrown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
