amaechler commented on PR #14356: URL: https://github.com/apache/druid/pull/14356#issuecomment-1569423897
Heya @kfaraz, thanks for your review! 🙇 > As for the java code, your changes do improve readability but it is still better to leave these changes to the next person touching these files for functional improvements. If you are updating the behaviour of these classes in any of your other PRs, you can include these there. Do you think the benefit of a slightly cleaner git history outweighs leaving non-functional cleanups like these up for another day? Personally, I feel any updates similar to this one benefit future developers more than a clean history, and we should encourage anyone to make similar updates. After all, what are the chances that the next person touching the codebase will catch the exact same thing? However, I of course can easily revert any of the Java comments if you feel strongly about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
