abhishekrb19 commented on code in PR #14352:
URL: https://github.com/apache/druid/pull/14352#discussion_r1212470584
##########
sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/EarliestLatestBySqlAggregator.java:
##########
@@ -168,12 +168,12 @@ private static class EarliestByLatestBySqlAggFunction
extends SqlAggFunction
InferTypes.RETURN_TYPE,
OperandTypes.or(
OperandTypes.sequence(
- "'" + aggregatorType.name() + "(expr, timeColumn)'\n",
+ "'" + StringUtils.format("%s_BY", aggregatorType.name()) +
"(expr, timeColumn)'\n",
Review Comment:
also, fwiw, I'm intending to use this function signature by calling
`org.apache.calcite.sql.type.SqlOperandTypeChecker#getAllowedSignatures`
outlined in the [`INFORMATION_SCHEMA.ROUTINES` proposal](
https://github.com/apache/druid/issues/14346). So that's another use case in
addition to how we surface validation exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
