clintropolis commented on code in PR #14352:
URL: https://github.com/apache/druid/pull/14352#discussion_r1213945522
##########
sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/EarliestLatestBySqlAggregator.java:
##########
@@ -168,12 +168,12 @@ private static class EarliestByLatestBySqlAggFunction
extends SqlAggFunction
InferTypes.RETURN_TYPE,
OperandTypes.or(
OperandTypes.sequence(
- "'" + aggregatorType.name() + "(expr, timeColumn)'\n",
+ "'" + StringUtils.format("%s_BY", aggregatorType.name()) +
"(expr, timeColumn)'\n",
Review Comment:
>For the most part when OperandTypes.sequence is not present, Calcite gives
back a string with single quotes in them, but again there are exceptions for
things defined in Calcite internally
if calcite built-ins use single quotes then we should probably add single
quotes in our customized ones to be consistent-ish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
