kfaraz commented on code in PR #14271:
URL: https://github.com/apache/druid/pull/14271#discussion_r1214387376
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/http/OverlordResource.java:
##########
@@ -222,25 +222,19 @@ public Response taskPost(final Task task, @Context final
HttpServletRequest req)
return asLeaderWith(
taskMaster.getTaskQueue(),
- new Function<TaskQueue, Response>()
- {
- @Override
- public Response apply(TaskQueue taskQueue)
- {
- try {
- taskQueue.add(task);
- return Response.ok(ImmutableMap.of("task",
task.getId())).build();
- }
- catch (EntryExistsException e) {
- return Response.status(Response.Status.BAD_REQUEST)
- .entity(
- ImmutableMap.of(
- "error",
- StringUtils.format("Task[%s] already
exists!", task.getId())
- )
- )
- .build();
- }
+ taskQueue -> {
+ try {
+ taskQueue.add(task);
+ return Response.ok(ImmutableMap.of("task", task.getId())).build();
+ }
+ catch (DruidException e) {
+ return Response.status(e.getResponseCode())
+ .entity(ImmutableMap.of("error", e.getMessage()))
+ .build();
+ }
+ catch (Exception e) {
+ log.info("Got final exception [%s]", e.getClass());
Review Comment:
this was probably left over from my testing. thanks for catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
