abhishekrb19 commented on issue #14346: URL: https://github.com/apache/druid/issues/14346#issuecomment-1576085769
@abhishekagarwal87, thank you for the comments. Yes, removing `IS_DETERMINISTIC` sounds good. As a side note, we currently don't implement the [deterministic function](https://calcite.apache.org/javadocAggregate/org/apache/calcite/sql/SqlOperator.html#isDeterministic()), so it defaults to true for all functions. As far as `functionDescription` is concerned, my thought is we can fully update the description for _all_ functions in Apache Druid. The fallback null implementation proposed is only for proprietary ones in the wild. I updated the comment with a few applications. Specifically, our client won't need the function description right out of the bat; it's primarily for the Druid web-console and documentation purposes, so I will follow that up after the main work is complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
