cryptoe commented on code in PR #14382:
URL: https://github.com/apache/druid/pull/14382#discussion_r1223801048
##########
server/src/main/java/org/apache/druid/metadata/SQLMetadataSupervisorManager.java:
##########
@@ -259,7 +261,8 @@ public Pair<String, SupervisorSpec> map(int index,
ResultSet r, StatementContext
);
}
catch (IOException e) {
- throw new RuntimeException(e);
+ log.error(e, "Could not map json payload to a
SupervisorSpec for spec_id: [%s]", r.getString("spec_id"));
Review Comment:
Since this would be a customer facing exception, I had a few questions:
* Will the bad supervisor be shown in the ingestion tab
* If the bad supervisor is shown in the status tab, what would be the status
of the supervisor.
* If the bad supervisor is not shown in the status tab, could you please
make this error message more actionable. May be something like `Could not map
json payload to a SupervisorSpec for spec_id: [%s]. Please remove the
supervisor spec_id: [%s] from the database and then submit a new request via
the overlord.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
