findingrish commented on code in PR #14382:
URL: https://github.com/apache/druid/pull/14382#discussion_r1225339340
##########
server/src/main/java/org/apache/druid/metadata/SQLMetadataSupervisorManager.java:
##########
@@ -259,7 +261,8 @@ public Pair<String, SupervisorSpec> map(int index,
ResultSet r, StatementContext
);
}
catch (IOException e) {
- throw new RuntimeException(e);
+ log.error(e, "Could not map json payload to a
SupervisorSpec for spec_id: [%s]", r.getString("spec_id"));
Review Comment:
At present, this supervisor will not be removed within `KillSupervisors`
since the `getLatest` method won't return it.
I am wondering whether the removal of this supervisor from db should be
handled within `KillSupervisors` coordinator duty or if it should be left for
the users to manage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
