imply-cheddar commented on PR #14004: URL: https://github.com/apache/druid/pull/14004#issuecomment-1588397747
@abhishekagarwal87 once again, you've provided a great example! Essentially, you went through the thought process that I'm hoping we can just do as a part of every exception message that we generate. In this case, making it ADMIN-focused and having more details about server names and stuff makes a lot of sense to me. And the argument that someone who is trying to "hide" Druid should be able to siphon off this message makes a lot of sense to me too. So, I think that I'm now convinced that the message in question *should* be targeting the ADMIN persona and specifically mention that you should check that the brokers are up and running. To me, this type of conversation, back-and-forth and your eventual conclusion is the whole goal of the adjustments to the error messages. And, once we change that exception to be ADMIN focused, the code will include the fact that this is an ADMIN-focused message. So any future person who comes across it can clearly see the intentions of who gets the message and why, if they feel the message needs updating, they can have their own internal dialog and motivate their feelings by either saying it should target a different persona OR it needs more details to target the current persona. So anyway, I think that yes, you are thinking along the same lines that I'm thinking at this point. I'm all for adding documentation about whatever, but I'm unclear on where you think it would be added for the most impact. Ultimately, this has to become part of the culture of the project rather than be a pure documentation thing, but I can document it anywhere you think it can help ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
