kfaraz commented on code in PR #13197:
URL: https://github.com/apache/druid/pull/13197#discussion_r1231758154
##########
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java:
##########
@@ -194,21 +211,46 @@ public CoordinatorDynamicConfig(
+ "reflect this configuration being added to Druid in a recent
release. Druid is defaulting the value "
+ "to the Druid default of %d. It is recommended that you re-submit
your dynamic config with your "
+ "desired value for maxNonPrimaryReplicantsToLoad",
- Builder.DEFAULT_MAX_NON_PRIMARY_REPLICANTS_TO_LOAD
+ Defaults.MAX_NON_PRIMARY_REPLICANTS_TO_LOAD
);
- maxNonPrimaryReplicantsToLoad =
Builder.DEFAULT_MAX_NON_PRIMARY_REPLICANTS_TO_LOAD;
+ maxNonPrimaryReplicantsToLoad =
Defaults.MAX_NON_PRIMARY_REPLICANTS_TO_LOAD;
}
Preconditions.checkArgument(
maxNonPrimaryReplicantsToLoad >= 0,
"maxNonPrimaryReplicantsToLoad must be greater than or equal to 0."
);
this.maxNonPrimaryReplicantsToLoad = maxNonPrimaryReplicantsToLoad;
- if (useRoundRobinSegmentAssignment == null) {
- this.useRoundRobinSegmentAssignment =
Builder.DEFAULT_USE_ROUND_ROBIN_ASSIGNMENT;
- } else {
- this.useRoundRobinSegmentAssignment = useRoundRobinSegmentAssignment;
+ this.useRoundRobinSegmentAssignment = Builder.valueOrDefault(
+ useRoundRobinSegmentAssignment,
+ Defaults.USE_ROUND_ROBIN_ASSIGNMENT
+ );
+ this.debugDimensions = debugDimensions;
+ this.validDebugDimensions = validateDebugDimensions(debugDimensions);
+ }
+
+ private Map<Dimension, String> validateDebugDimensions(Map<String, String>
debugDimensions)
+ {
+ final Map<Dimension, String> validDebugDimensions = new
EnumMap<>(Dimension.class);
+ if (debugDimensions == null || debugDimensions.isEmpty()) {
+ return validDebugDimensions;
+ }
+
+ final Map<String, Dimension> nameToDimension = new HashMap<>();
+ for (Dimension dimension : Dimension.values()) {
+ nameToDimension.put(dimension.reportedName(), dimension);
}
+
+ debugDimensions.forEach(
+ (dimensionName, value) -> {
+ Dimension dimension = nameToDimension.get(dimensionName);
+ if (dimension != null && value != null) {
+ validDebugDimensions.put(dimension, value);
+ }
+ }
+ );
Review Comment:
Don't know why I had done it in such a round about way in the first place 😅
, thanks for pointing this out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
