kfaraz commented on code in PR #13197:
URL: https://github.com/apache/druid/pull/13197#discussion_r1232279827
##########
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java:
##########
@@ -428,66 +489,36 @@ public boolean equals(Object o)
CoordinatorDynamicConfig that = (CoordinatorDynamicConfig) o;
- if (leadingTimeMillisBeforeCanMarkAsUnusedOvershadowedSegments !=
- that.leadingTimeMillisBeforeCanMarkAsUnusedOvershadowedSegments) {
- return false;
- }
- if (mergeBytesLimit != that.mergeBytesLimit) {
- return false;
- }
- if (mergeSegmentsLimit != that.mergeSegmentsLimit) {
- return false;
- }
- if (maxSegmentsToMove != that.maxSegmentsToMove) {
- return false;
- }
- if (percentOfSegmentsToConsiderPerMove !=
that.percentOfSegmentsToConsiderPerMove) {
- return false;
- }
- if (useBatchedSegmentSampler != that.useBatchedSegmentSampler) {
- return false;
- }
- if (replicantLifetime != that.replicantLifetime) {
- return false;
- }
- if (replicationThrottleLimit != that.replicationThrottleLimit) {
- return false;
- }
- if (balancerComputeThreads != that.balancerComputeThreads) {
- return false;
- }
- if (emitBalancingStats != that.emitBalancingStats) {
- return false;
- }
- if (maxSegmentsInNodeLoadingQueue != that.maxSegmentsInNodeLoadingQueue) {
- return false;
- }
- if (!Objects.equals(specificDataSourcesToKillUnusedSegmentsIn,
that.specificDataSourcesToKillUnusedSegmentsIn)) {
- return false;
- }
- if (!Objects.equals(dataSourcesToNotKillStalePendingSegmentsIn,
that.dataSourcesToNotKillStalePendingSegmentsIn)) {
- return false;
- }
- if (!Objects.equals(decommissioningNodes, that.decommissioningNodes)) {
- return false;
- }
- if (pauseCoordination != that.pauseCoordination) {
- return false;
- }
- if (replicateAfterLoadTimeout != that.replicateAfterLoadTimeout) {
- return false;
- }
- if (maxNonPrimaryReplicantsToLoad != that.maxNonPrimaryReplicantsToLoad) {
- return false;
- }
- return decommissioningMaxPercentOfMaxSegmentsToMove ==
that.decommissioningMaxPercentOfMaxSegmentsToMove;
+ return markSegmentAsUnusedDelayMillis ==
that.markSegmentAsUnusedDelayMillis
+ && mergeBytesLimit == that.mergeBytesLimit
+ && mergeSegmentsLimit == that.mergeSegmentsLimit
+ && maxSegmentsToMove == that.maxSegmentsToMove
+ && percentOfSegmentsToConsiderPerMove ==
that.percentOfSegmentsToConsiderPerMove
+ && decommissioningMaxPercentOfMaxSegmentsToMove ==
that.decommissioningMaxPercentOfMaxSegmentsToMove
+ && useBatchedSegmentSampler == that.useBatchedSegmentSampler
+ && balancerComputeThreads == that.balancerComputeThreads
+ && emitBalancingStats == that.emitBalancingStats
+ && replicantLifetime == that.replicantLifetime
+ && replicationThrottleLimit == that.replicationThrottleLimit
+ && replicateAfterLoadTimeout == that.replicateAfterLoadTimeout
+ && maxSegmentsInNodeLoadingQueue ==
that.maxSegmentsInNodeLoadingQueue
+ && maxNonPrimaryReplicantsToLoad ==
that.maxNonPrimaryReplicantsToLoad
+ && useRoundRobinSegmentAssignment ==
that.useRoundRobinSegmentAssignment
+ && pauseCoordination == that.pauseCoordination
+ && Objects.equals(
+ specificDataSourcesToKillUnusedSegmentsIn,
+ that.specificDataSourcesToKillUnusedSegmentsIn)
+ && Objects.equals(
+ dataSourcesToNotKillStalePendingSegmentsIn,
+ that.dataSourcesToNotKillStalePendingSegmentsIn)
+ && Objects.equals(decommissioningNodes, that.decommissioningNodes);
Review Comment:
I was even thinking of getting rid of the `equals` and `hashCode` in this
class. Don't see them serving any purpose (unless the `JsonConfigProvider` does
something with it, need to double check). Even the tests do an item-by-item
comparison. But will do it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
