abhishekrb19 opened a new pull request, #14441:
URL: https://github.com/apache/druid/pull/14441
This PR makes a few improvements to the `EXPLAIN PLAN` attributes structure:
- Use the already computed targetDatasource and partitioned by information
extracted from the `SqlNode`
- For the clustered by columns, the output names are derived and resolved
from the clustered by `SqlNodeList` and the select `SqlNode`. Also, see the
corresponding unit tests
- Return a json array instead of comma-delimited string for `clusteredBy`
- Updated docs with an `INSERT` example query and result. Also, added
collapsible html tags for the sql query and json result, so the examples don't
clutter or distract the reader.
These change also make it consistent with rest of the fields in `EXPLAIN
PLAN` result.
##### Key changed/added classes in this PR
* `ExplainAttributes.java`
* `DruidSqlParserUtils.java`
* `ExplainAttributesTest.java`
* `DruidSqlParserUtilsTest.java`
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [x] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
