clintropolis opened a new pull request, #14461:
URL: https://github.com/apache/druid/pull/14461

   
   Mostly fixes #14374. The first expression will currently throw a class cast 
exception because it is trying to cast `ARRAY<STRING>` to `STRING` because it 
seems that by default the query plans to 'RETURNING VARCHAR' instead of using 
JSON_VALUE_ANY, will work on resolving that in a different PR.
   
   ### Description
   The `JSON_VALUE` expression (e.g. when not using the specialized 
`NestedFieldVirtualColumn`) was using a stale method that predated support for 
returning arrays, which would always return null if the value was an object or 
an array. This method has been removed so that the `JSON_VALUE` expression now 
matches the behavior of `JSON_VALUE` using `NestedFieldVirtualColumn`.
   <hr>
   
   This PR has:
   
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to